Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flax: add shape argument to set_timesteps #690

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Sep 30, 2022

There was a discussion in #583 and/or Slack about sending the latents shape to the Flax scheduler, because PNDM requires it to properly initialize the state. We agreed to send the shape to all of them (until we maybe find a better solution), but I only ever added it to PNDM. Therefore, the stable diffusion pipeline was failing with other schedulers. For example, with the default weights that were uploaded to the repo for testing.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 30, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pcuenca pcuenca merged commit 249b36c into main Oct 3, 2022
@pcuenca pcuenca deleted the fix-flax-schedulers branch October 3, 2022 13:07
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
* Flax: add shape argument to set_timesteps

* style
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Flax: add shape argument to set_timesteps

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants