Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters and fixed FutureWarning #6317

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Remove unused parameters and fixed FutureWarning #6317

merged 3 commits into from
Dec 26, 2023

Conversation

Justin900429
Copy link
Contributor

What does this PR do?

Remove unused parameters for DDIMInverseScheduler and fix the FutureWarning about accessing the instance directly with self.

FutureWarning: Accessing config attribute `num_train_timesteps` directly via 'DDIMInverseScheduler' object attribute is deprecated. Please access 'num_train_timesteps' over 'DDIMInverseScheduler's config object instead, e.g. 'scheduler.config.num_train_timesteps'.
  deprecate("direct config name access", "1.0.0", deprecation_message, standard_warn=False)

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul requested a review from yiyixuxu December 25, 2023 15:51
@patrickvonplaten
Copy link
Contributor

Thanks!

@patrickvonplaten patrickvonplaten merged commit 6e12368 into huggingface:main Dec 26, 2023
14 checks passed
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
@Justin900429 @donhardman
Remove unused parameters and fixed FutureWarning (huggingface#6317)
c8eb41a 
* Remove unused parameters and fixed `FutureWarning`

* Fixed wrong config instance

* update unittest for `DDIMInverseScheduler`
antoine-scenario pushed a commit to antoine-scenario/diffusers that referenced this pull request Jan 2, 2024
@Justin900429 @adrvs
Remove unused parameters and fixed FutureWarning (huggingface#6317)
fc7f072 
* Remove unused parameters and fixed `FutureWarning`

* Fixed wrong config instance

* update unittest for `DDIMInverseScheduler`
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@Justin900429
Remove unused parameters and fixed FutureWarning (huggingface#6317)
e69111d 
* Remove unused parameters and fixed `FutureWarning`

* Fixed wrong config instance

* update unittest for `DDIMInverseScheduler`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justin900429 @HuggingFaceDocBuilderDev @patrickvonplaten