Fix LCM distillation bug when creating the guidance scale embeddings using multiple GPUs. #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg845
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@patil-suraj can you take a look here? |
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
…using multiple GPUs. (huggingface#6279) Fix bug when creating the guidance embeddings using multiple GPUs. Co-authored-by: Sayak Paul <[email protected]>
antoine-scenario
pushed a commit
to antoine-scenario/diffusers
that referenced
this pull request
Jan 2, 2024
…using multiple GPUs. (huggingface#6279) Fix bug when creating the guidance embeddings using multiple GPUs. Co-authored-by: Sayak Paul <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…using multiple GPUs. (huggingface#6279) Fix bug when creating the guidance embeddings using multiple GPUs. Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in the LCM full model distillation scripts: when using multiple GPUs, attempting to creating the guidance scale embedding
w_embeddingraises an error becauseunet.config.time_cond_proj_dimcan't be accessed sinceunetis wrapped byaccelerate.Fixes #6278. Bug discovered by @akameswa.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten
@patil-suraj
@sayakpaul