Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDXL-IP2P] Update README_sdxl, Replace the link for wandb log with the correct run #6270

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

priprapre
Copy link
Contributor

What does this PR do?

It replaces the wandb run with the correct link in README_sdxl.md for instructpix2pix training. The new link for wandb run is from the diffusers/sdxl-instructpix2pix-768 model page. (The old one was pointing to SD1.5 instructpix2pix run)

I think there is a typo on the model page as well. It says that batch size per GPU is 8 (x4 gradient accumulation=32) but in the wandb run, I see that it's 4 (x4 gradient accumulation=16).

Besides, I observe that some parameters differ from the script on README_sdxl. For example, the diffusers/sdxl-instructpix2pix-768 model is trained with learning_rate=5e-06 and conditioning_dropout_prob=0.1 whereas the script defaults are 5e-05 and 0.05. Hyperparameters differ from SD1.5 IP2P training, so it might be useful to change those defaults for SDXL so that we would know which set of hyperparameters worked out well for SDXL case.
Maybe @harutatsuakiyama also has some insights here about the hyperparams working the best.

cc: @sayakpaul

@sayakpaul
Copy link
Member

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@patrickvonplaten patrickvonplaten merged commit fa31704 into huggingface:main Dec 26, 2023
14 checks passed
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
…he correct run (huggingface#6270)

Replace the link for wandb log with the correct run
antoine-scenario pushed a commit to antoine-scenario/diffusers that referenced this pull request Jan 2, 2024
…he correct run (huggingface#6270)

Replace the link for wandb log with the correct run
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…he correct run (huggingface#6270)

Replace the link for wandb log with the correct run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants