Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IP Adapter implementation to latest #6115

Closed
wants to merge 1 commit into from

Conversation

a-r-r-o-w
Copy link
Member

What does this PR do?

After #5915, some pipelines are not yet updated to the latest implementation for IP Adapter Plus.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten @sayakpaul

@charchit7
Copy link
Contributor

LGTM

@sayakpaul
Copy link
Member

Could you add some results and also update the REAMDEs accordingly?

@sayakpaul
Copy link
Member

Also ccing @TonyLianLong for the changes introduced in LLM-grounded diffusion.

@a-r-r-o-w
Copy link
Member Author

Could you add some results and also update the REAMDEs accordingly?

@sayakpaul I updated the implementations to match the changes introduced in 5915. However, I can't seem to get IP Adapter Plus to load with LLM Grounded Diffusion due to size mismatch in weights. It's probably just me doing something wrong but would you be willing to take a look as well @TonyLianLong? Thanks. I'll look into it further soon.

Copy link

github-actions bot commented Jan 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 9, 2024
@github-actions github-actions bot closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants