Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Euler Discrete] do sigmas edits from the pipeline. #6081

Closed
wants to merge 4 commits into from

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Fixes the issue for which #6078 was made.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Collaborator

DN6 commented Dec 7, 2023

@sayakpaul
Copy link
Member Author

@DN6 could you give this another look?

@sayakpaul
Copy link
Member Author

@patrickvonplaten @DN6

Since the concerned change is very specific to the torch.compile() performance how about we do from the pipeline calling script?

pipe.scheduler.sigmas = pipe.scheduler.sigmas.tolist()

This essentially solves the purpose. In retrospect, I think we shouldn't touch the internals and instead leverage what we can to keep changes more explicit.

@sayakpaul
Copy link
Member Author

Closing because we can simply do: pipeline.scheduler.sigmas = pipeline.scheduler.sigmas.cpu() from the pipeline calling script.

@sayakpaul sayakpaul closed this Dec 9, 2023
@sayakpaul sayakpaul deleted the fix/euler-discrete-sigmas branch December 9, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants