Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging step_loss to a tracker #6053

Closed
wants to merge 2 commits into from
Closed

Add logging step_loss to a tracker #6053

wants to merge 2 commits into from

Conversation

kopyl
Copy link
Contributor

@kopyl kopyl commented Dec 5, 2023

What does this PR do?

Adds logging step_loss to a tracker

Who can review?

@sayakpaul
Copy link
Member

I think it's okay for us to keep the loss reporting as is. @patil-suraj WDYT?

@kopyl
Copy link
Contributor Author

kopyl commented Dec 5, 2023

@sayakpaul what do you mean? How am I supposed to see when it starts giving me a zero-step loss? sit 24/7 at my laptop?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@patrickvonplaten
Copy link
Contributor

I don't understand this change, the train_loss is enough for monitoring

@kopyl
Copy link
Contributor Author

kopyl commented Dec 7, 2023

@patrickvonplaten well, why in wandb the main train_loss is not at zero, but in tqdm logs it says step_loss: 0.00?

Initially train loss and step loss are the same, but over time step_loss becomes 0.00 and train_loss stays above...

@kopyl kopyl closed this by deleting the head repository Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants