Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logging] Fix assertion bug #6012

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[logging] Fix assertion bug #6012

merged 1 commit into from
Dec 1, 2023

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Dec 1, 2023

What does this PR do?

Fixes #519. It seems that this issue was closed without resolving.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@patrickvonplaten patrickvonplaten merged commit 5235070 into huggingface:main Dec 1, 2023
20 checks passed
@tolgacangoz tolgacangoz deleted the logging-bug branch December 1, 2023 18:16
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging.remove_handler() has a faulty assertion, doesn't allow registered handlers to be removed
2 participants