Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnboundLocalError in SDXLInpaint.prepare_latents() #5648

Merged
merged 7 commits into from
Nov 20, 2023
Merged

UnboundLocalError in SDXLInpaint.prepare_latents() #5648

merged 7 commits into from
Nov 20, 2023

Conversation

a-r-r-o-w
Copy link
Member

What does this PR do?

Fixes #5647.

Before submitting

Who can review?

@patrickvonplaten @sayakpaul

@a-r-r-o-w a-r-r-o-w changed the title Sdxl bug UnboundLocalError in SDXLInpaint.prepare_latents() Nov 5, 2023
@a-r-r-o-w a-r-r-o-w closed this Nov 5, 2023
@a-r-r-o-w a-r-r-o-w reopened this Nov 5, 2023
@a-r-r-o-w a-r-r-o-w closed this Nov 6, 2023
@a-r-r-o-w a-r-r-o-w deleted the sdxl_bug branch November 7, 2023 11:40
@a-r-r-o-w a-r-r-o-w restored the sdxl_bug branch November 17, 2023 06:06
@a-r-r-o-w a-r-r-o-w reopened this Nov 17, 2023
yiyixuxu
yiyixuxu reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you!
maybe revert the change to alt_diffusion and make sure the code quality tests pass :)

src/diffusers/pipelines/alt_diffusion/pipeline_alt_diffusion.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 17, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu November 17, 2023 13:02
@yiyixuxu yiyixuxu requested a review from DN6 November 17, 2023 20:20
DN6
DN6 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@yiyixuxu yiyixuxu merged commit 4adad57 into huggingface:main Nov 20, 2023
14 checks passed
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@a-r-r-o-w @yiyixuxu
UnboundLocalError in SDXLInpaint.prepare_latents() (huggingface#5648)
fdda928 
* fix: UnboundLocalError with image_latents

* chore: run make style, quality, fix-copies

* revert changes from make fix-copies

* revert changes from make fix-copies

---------

Co-authored-by: YiYi Xu <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@a-r-r-o-w @yiyixuxu
UnboundLocalError in SDXLInpaint.prepare_latents() (huggingface#5648)
a988572 
* fix: UnboundLocalError with image_latents

* chore: run make style, quality, fix-copies

* revert changes from make fix-copies

* revert changes from make fix-copies

---------

Co-authored-by: YiYi Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DN6 DN6 DN6 approved these changes

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in StableDiffusionXLInpaintPipeline when strength==1
4 participants
@a-r-r-o-w @HuggingFaceDocBuilderDev @DN6 @yiyixuxu