Revert "Fix the order of width and height of original size in SDXL training script" #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was indeed incorrect, the correct order is height, width not width, height which can also be seen here: https://github.com/Stability-AI/generative-models/blob/477d8b9a7730d9b2e92b326a770c0420d00308c9/scripts/demo/streamlit_helpers.py#L620 |
patrickvonplaten
deleted the
revert-5382-linjia-sdxl-training-original-size-fix
branch
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
…aining script" (huggingface#5614) Revert "Fix the order of width and height of original size in SDXL training script (huggingface#5382)" This reverts commit 45db049.
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…aining script" (huggingface#5614) Revert "Fix the order of width and height of original size in SDXL training script (huggingface#5382)" This reverts commit 45db049.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5382