Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Redundant Variables from Encoder and Decoder #5569

Merged
merged 22 commits into from
Nov 1, 2023
Merged

Remove Redundant Variables from Encoder and Decoder #5569

merged 22 commits into from
Nov 1, 2023

Conversation

hi-sushanta
Copy link
Contributor

@hi-sushanta hi-sushanta commented Oct 29, 2023 •
edited
Loading

I removed the dummy variable defined in both the encoder and decoder.

  • First Encoder part:

Replace x with sample

  • Second Decoder part:

Replace z with sample

Before submitting

hi-sushanta and others added 21 commits October 5, 2023 06:34
@hi-sushanta
I added a new doc string to the class. This is more flexible to under…
8425cd4 
…standing other developers what are doing and where it's using.
@hi-sushanta
Merge branch 'main' into doc_string
8a0e77d
@hi-sushanta
Merge branch 'main' into doc_string
cf3a816
@hi-sushanta
Merge branch 'main' into doc_string
a0cd96f
@hi-sushanta @sayakpaul
Update src/diffusers/models/unet_2d_blocks.py
746a8e8 
This changes suggest by maintener.

Co-authored-by: Sayak Paul <[email protected]>
@hi-sushanta @sayakpaul
Update src/diffusers/models/unet_2d_blocks.py
6e56886 
Add suggested text

Co-authored-by: Sayak Paul <[email protected]>
@hi-sushanta
Update unet_2d_blocks.py
627fd9f 
I changed the Parameter to Args text.
@hi-sushanta
Update unet_2d_blocks.py
ae4f7f2 
proper indentation set in this file.
@hi-sushanta
Update unet_2d_blocks.py
f0bea43 
a little bit of change in the act_fun argument line.
@hi-sushanta
Merge branch 'main' into doc_string
872a4a5
@hi-sushanta
I run the black command to reformat style in the code
3546f6d
@hi-sushanta
Merge branch 'main' into doc_string
12534f4
@hi-sushanta
Merge branch 'main' into doc_string
48afb4b
@hi-sushanta
Merge pull request #1 from hi-sushanta/doc_string
0bb06b6 
Doc string
@hi-sushanta
Update unet_2d_blocks.py
01a9fc9 
similar doc-string add to have in the original diffusion repository.
@hi-sushanta
Merge branch 'huggingface:main' into main
04e6efb
@hi-sushanta
Merge branch 'huggingface:main' into main
d695c4a
@hi-sushanta
Merge branch 'huggingface:main' into main
27d8002
@hi-sushanta
Merge branch 'huggingface:main' into main
55001e3
@hi-sushanta
I removed the dummy variable defined in both the encoder and decoder.
57d534a
@hi-sushanta
Now, I run black package to reformat my file
1fdcd40
@DN6 DN6 self-requested a review October 31, 2023 06:05
DN6
DN6 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

@hi-sushanta
Copy link
Contributor Author

Thank you🤗 @DN6

@patrickvonplaten patrickvonplaten merged commit 29cf163 into huggingface:main Nov 1, 2023
11 checks passed
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
@hi-sushanta @sayakpaul
@DN6 @kashif
Remove Redundant Variables from Encoder and Decoder (huggingface#5569)
f23e44e 
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.

* Update src/diffusers/models/unet_2d_blocks.py

This changes suggest by maintener.

Co-authored-by: Sayak Paul <[email protected]>

* Update src/diffusers/models/unet_2d_blocks.py

Add suggested text

Co-authored-by: Sayak Paul <[email protected]>

* Update unet_2d_blocks.py

I changed the Parameter to Args text.

* Update unet_2d_blocks.py

proper indentation set in this file.

* Update unet_2d_blocks.py

a little bit of change in the act_fun argument line.

* I run the black command to reformat style in the code

* Update unet_2d_blocks.py

similar doc-string add to have in the original diffusion repository.

* I removed the dummy variable defined in both the encoder and decoder.

* Now, I run black package to reformat my file

---------

Co-authored-by: Sayak Paul <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@hi-sushanta @sayakpaul @DN6
Remove Redundant Variables from Encoder and Decoder (huggingface#5569)
ffef55d 
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.

* Update src/diffusers/models/unet_2d_blocks.py

This changes suggest by maintener.

Co-authored-by: Sayak Paul <[email protected]>

* Update src/diffusers/models/unet_2d_blocks.py

Add suggested text

Co-authored-by: Sayak Paul <[email protected]>

* Update unet_2d_blocks.py

I changed the Parameter to Args text.

* Update unet_2d_blocks.py

proper indentation set in this file.

* Update unet_2d_blocks.py

a little bit of change in the act_fun argument line.

* I run the black command to reformat style in the code

* Update unet_2d_blocks.py

similar doc-string add to have in the original diffusion repository.

* I removed the dummy variable defined in both the encoder and decoder.

* Now, I run black package to reformat my file

---------

Co-authored-by: Sayak Paul <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@hi-sushanta @sayakpaul @DN6
Remove Redundant Variables from Encoder and Decoder (huggingface#5569)
61b6743 
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.

* Update src/diffusers/models/unet_2d_blocks.py

This changes suggest by maintener.

Co-authored-by: Sayak Paul <[email protected]>

* Update src/diffusers/models/unet_2d_blocks.py

Add suggested text

Co-authored-by: Sayak Paul <[email protected]>

* Update unet_2d_blocks.py

I changed the Parameter to Args text.

* Update unet_2d_blocks.py

proper indentation set in this file.

* Update unet_2d_blocks.py

a little bit of change in the act_fun argument line.

* I run the black command to reformat style in the code

* Update unet_2d_blocks.py

similar doc-string add to have in the original diffusion repository.

* I removed the dummy variable defined in both the encoder and decoder.

* Now, I run black package to reformat my file

---------

Co-authored-by: Sayak Paul <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DN6 DN6 DN6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hi-sushanta @DN6 @patrickvonplaten