-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese docs #5478
Japanese docs #5478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👏
You'll also need to modify the build_documentation.yml
and build_pr_documentation.yml
file to include the language code for Japanese (ja
) to build the docs.
@stevhliu Thanks for the review! And should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, just two minor ones remaining :)
The documentation is not available anymore as the PR was closed or merged. |
@stevhliu Forgot to say but should be done! Fixed the folder name to jp->ja too |
Thanks again for your contribution! 🤗 |
* Finished _toctree.yml and index.md * Finished installation.md * Properly finished installation.md and almost finished quicktour * Finished quicktour * Finished stable diffusion doc * Fixed _toctree.yml * Fixed requests * Fix country code * Properly push
* Finished _toctree.yml and index.md * Finished installation.md * Properly finished installation.md and almost finished quicktour * Finished quicktour * Finished stable diffusion doc * Fixed _toctree.yml * Fixed requests * Fix country code * Properly push
What does this PR do?
Adds Japanese documentations
Fixes #5285
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Since, it's the docs, also @stevhliu and @yiyixuxu