Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slow Tests #5469

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix Slow Tests #5469

merged 1 commit into from
Oct 23, 2023

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Oct 20, 2023

What does this PR do?

Switching to Torch 2.1 in the test runners resulted in a few failures on the slow tests.

This PR

  1. Bumps up the precision / updates expected slices on a few of the failing tests
  2. Updates the memory values in the SD v prediction test so that is passes. Torch 2.1 seems to provide more memory savings by default, so this value can be lowered.
  3. Reintroduces pytorch_lightning as a test dependency. SD from_single_file checkpoints are serialised using pytorch_lightning modules, so these tests are breaking because we removed this dependency.
  4. Breaks up T2IAdapters into individual tests for easier debugging

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from patrickvonplaten October 20, 2023 11:26
@DN6
Copy link
Collaborator Author

DN6 commented Oct 23, 2023

@patrickvonplaten gentle ping.

@patrickvonplaten patrickvonplaten merged commit 33293ed into main Oct 23, 2023
@patrickvonplaten
Copy link
Contributor

Thanks!

linoytsaban pushed a commit to linoytsaban/diffusers that referenced this pull request Oct 24, 2023
@kashif kashif deleted the precision-test-fixes branch November 1, 2023 17:23
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants