-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] General updates #5378
[docs] General updates #5378
Conversation
@@ -1,36 +0,0 @@ | |||
<!--Copyright 2023 The HuggingFace Team. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm where is the diffusion pipeline now shown instead? The DiffusionPipeline
is a very important object no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diffusion pipeline is shown here with the pipeline overview similar to how we show the base scheduler/model classes on their overview pages.
| [DiffEdit](diffedit) | inpainting | | ||
| [DiT](dit) | text2image | | ||
| [GLIGEN](gligen) | text2image | | ||
| [InstructPix2Pix](pix2pix) | image editing | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we're missing DeepFloyd's IF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeepFloyd IF should be on line 42 :)
|
||
| Example | Description | Code Example | Colab | Author | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have the table? Gives a nice overview no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more lightweight to let the table here provide the overview, and we can keep a link to it from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changes!
613057b
to
bfb2d77
Compare
|
||
<Tip> | ||
|
||
You shouldn't use the [`DiffusionPipeline`] class for training or finetuning a diffusion model. Individual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it make sense to move this Tip over or the other Diffusion Pipeline doc? It's a bit different from what is there already, but might be useful!
The documentation is not available anymore as the PR was closed or merged. |
* first draft * feedback * feedback
* first draft * feedback * feedback
Implements some of the easier improvements that we discussed:
index
to the pipelines overviewDiffusionPipeline
API page here because it is already documented in the pipelines overview