Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSQL as a possible viewer #3121

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add PostgreSQL as a possible viewer #3121

merged 2 commits into from
Dec 18, 2024

Conversation

cevian
Copy link
Contributor

@cevian cevian commented Dec 17, 2024

Add documentation for how to use PostgreSQL with pgai to access the dataset.

Add documentation for how to use PostgreSQL with pgai to access the dataset.
@@ -44,6 +44,8 @@
title: Pandas
- local: polars
title: Polars
- local: postgresql
title: PostgreSQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add the link inside parquet_process.md?

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool addition!

could make sense to add it to https://huggingface.co/docs/hub/datasets-libraries too in the future, maybe

docs/source/postgresql.md Outdated Show resolved Hide resolved
@cevian
Copy link
Contributor Author

cevian commented Dec 18, 2024

@julien-c addressed your comments. Yeah https://huggingface.co/docs/hub/datasets-libraries would be cool. Do you think we should try to get Push to hub abilities in before we do that?

@cevian cevian requested a review from julien-c December 18, 2024 13:46
@julien-c
Copy link
Member

Push to hub would be awesome! do you see some demand for this from pgai users?

@cevian
Copy link
Contributor Author

cevian commented Dec 18, 2024

Not yet. But we've just added load_datasets so I think it will take people a bit to catch on.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pinging @lhoestq for a review but this PR lgtm

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Also interested in a push to hub feature, but not need for it to start sharing about this online imo !

Let me know if you post about it online I can re-share with the community :)

Btw I've seen people interested in RAG applications for code documentation lately, let me know if you ever do a demo on this topic

could make sense to add it to https://huggingface.co/docs/hub/datasets-libraries too in the future, maybe

We might re-organize this indeed, it's a bit suprising to me to have libraries in the Viewer's docs compared to libraries integrated with the Hub directly (especially for tools like pgai that provide deep integrations). Anyway I'll keep you posted if we move this page to make it more visible :)

@lhoestq lhoestq merged commit 5e9371a into huggingface:main Dec 18, 2024
3 checks passed
@cevian
Copy link
Contributor Author

cevian commented Dec 19, 2024

@lhoestq we shared this here: X post and on linkedIn and on bsky. Thanks for re-sharing,

I'll let you know about demos involving code documentation for sure.

@lhoestq
Copy link
Member

lhoestq commented Dec 23, 2024

Awesome ! glad to see it's getting good reception as well :)

I'll let you know about demos involving code documentation for sure.

ok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants