Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warnings in Docker Compose #3120

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Fix Warnings in Docker Compose #3120

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea178f9
update makefiles and .yml files for docker
ParagEkbote Dec 13, 2024
a7f7759
Merge branch 'main' into fix-makefile
ParagEkbote Dec 13, 2024
7441f9a
Merge branch 'main' into fix-makefile
ParagEkbote Dec 19, 2024
bb0bf07
Merge branch 'main' into fix-makefile
ParagEkbote Dec 20, 2024
4a1c0a9
Merge branch 'main' into fix-makefile
ParagEkbote Jan 6, 2025
81e8721
Add environment variables in makefiles.
ParagEkbote Jan 11, 2025
ebc5fe2
Remove unused variable
ParagEkbote Jan 11, 2025
20d7a26
Move variables to Makefile.
ParagEkbote Jan 13, 2025
d1dade0
Remove spacing.
ParagEkbote Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions e2e/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export ADMIN_UVICORN_NUM_WORKERS := 2
export ADMIN_UVICORN_PORT := 9081
export API_HF_JWT_ALGORITHM := EdDSA
export API_HF_JWT_PUBLIC_KEY_URL := https://hub-ci.huggingface.co/api/keys/jwt
export API_HF_JWT_ADDITIONAL_PUBLIC_KEYS :=
# ^ it's not tested in the e2e tests, but it's good to ensure we're able to fetch it at least.
export ADMIN_HF_TIMEOUT_SECONDS := 10
export API_HF_TIMEOUT_SECONDS := 10
Expand Down
3 changes: 3 additions & 0 deletions tools/Docker.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
export API_HF_JWT_PUBLIC_KEY_URL := https://hub-ci.huggingface.co/api/keys/jwt
export API_HF_JWT_ADDITIONAL_PUBLIC_KEYS :=
ParagEkbote marked this conversation as resolved.
Show resolved Hide resolved

.PHONY: down
down:
docker compose -f $(DOCKER_COMPOSE) down --remove-orphans --volumes
Expand Down