Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioCell - set audio type to string #3109

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

cfahlgren1
Copy link
Contributor

We are adding support for more generic types for the SQL Console in the AudioCell Internal PR.

@cfahlgren1 cfahlgren1 requested review from severo and lhoestq December 6, 2024 14:14
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@cfahlgren1
Copy link
Contributor Author

@severo went ahead and made the width and height optional while we are at it

@cfahlgren1 cfahlgren1 requested a review from severo December 6, 2024 14:25
@cfahlgren1 cfahlgren1 requested a review from severo December 6, 2024 15:03
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Better now by relaxing the constraint, even if the API will always return height and width for now

@cfahlgren1 cfahlgren1 merged commit eef00c2 into main Dec 6, 2024
6 of 7 checks passed
@cfahlgren1 cfahlgren1 deleted the cfahlgren1/update-openapi-audio-type branch December 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants