-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove support for script-based datasets #3046
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
todo:
removedhub_responses_external_files code errors to be removedUnsupportedExternalFilesError -> 1 |
hmmm the CI tests for services/worker fail if run serially, but not individually. Maybe we should create the repos when needed, not for the whole session. I think it's due, for some reason, to the fact that we already accessed the gated (or the private) dataset, and it's in the cache. If I delete the cache directory for the gated dataset in ~/.cache/huggingface/..., I get the correct behavior (no token = no access). It means that, for some reason, we don't create a specific cache directory for the worker ( |
OK!!!! Not related at all with this PR. The reason is that in the tests, we use the global datasets cache, not the temporary cache, because |
cb9c1d5
to
9ecd26d
Compare
fixed in #3047 + rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
This simplifies a lot the code and makes it more robust against security threats.
OK, gogogo |
fixes #3004