Stats for datetimes #3007
Draft
Stats for datetimes #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinaeterna
force-pushed
the
datetime-stats
branch
from
06cbfed to
79790e0
Compare
polinaeterna
commented
Dec 27, 2024
|
|
||
|
|
||
| class Histogram(TypedDict): | ||
| hist: list[int] | ||
| bin_edges: list[Union[int, float]] | ||
|
|
||
|
|
||
| class DatetimeHistogram(TypedDict): | ||
| hist: list[int] | ||
| bin_edges: list[str] # edges are string representations of dates |
There was a problem hiding this comment.
orjson supports datetime serialization though, maybe I should return datetimes then?
| transformed_column_name: str, | ||
| min_date: datetime.datetime, | ||
| ) -> pl.DataFrame: | ||
| return data.select((pl.col(column_name) - min_date).dt.total_seconds().alias(transformed_column_name)) |
There was a problem hiding this comment.
operate on seconds
currently not passing, bug on polars side?
…er into datetime-stats
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
not sure it works as expected
test fail is not reproduced locally
to debug why test is not passed in CI but works locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.