Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count image urls as image modality #2988

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Count image urls as image modality #2988

merged 6 commits into from
Jul 15, 2024

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Jul 12, 2024 •
edited
Loading

close #2970 for images (audio can be taken care of later)

@lhoestq lhoestq marked this pull request as ready for review July 15, 2024 16:21
severo
severo approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. See comments

Also: a small unit test for detect_modalities_from_url_columns?

services/worker/src/worker/job_runners/dataset/modalities.py Outdated Show resolved Hide resolved
services/worker/src/worker/job_runners/dataset/modalities.py Outdated Show resolved Hide resolved
@lhoestq lhoestq merged commit 2ff0da5 into main Jul 15, 2024
25 checks passed
@lhoestq lhoestq deleted the count-omage-urls-as-image-modality branch July 15, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severo severo severo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modalities] Account for image URLs dataset for Image modality
2 participants
@lhoestq @severo