Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove storage-admin #2808

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ jobs:
project: search
- directory: services
project: sse-api
- directory: services
project: storage-admin
- directory: services
project: worker
runs-on: "ubuntu-latest"
Expand Down Expand Up @@ -122,8 +120,6 @@ jobs:
tag: sha-${{ steps.vars.outputs.sha_short }}
sseApi:
tag: sha-${{ steps.vars.outputs.sha_short }}
storageAdmin:
tag: sha-${{ steps.vars.outputs.sha_short }}
worker:
tag: sha-${{ steps.vars.outputs.sha_short }}
END
Expand Down
4 changes: 0 additions & 4 deletions .vscode/monorepo.code-workspace
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@
"name": "services/sse-api",
"path": "../services/sse-api"
},
{
"name": "services/storage-admin",
"path": "../services/storage-admin"
},
{
"name": "services/worker",
"path": "../services/worker"
Expand Down
19 changes: 0 additions & 19 deletions chart/env/prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@ images:
useGlobalRegistry: false
repository: datasets-server-services-sse-api
tag: sha-fb3399a
storageAdmin:
registry: huggingface
useGlobalRegistry: false
repository: datasets-server-services-storage-admin
tag: sha-fb3399a
worker:
registry: huggingface
useGlobalRegistry: false
Expand Down Expand Up @@ -257,20 +252,6 @@ cacheMetricsCollector:
cpu: 1
memory: "512Mi"

# --- storage admin (to manually inspect the storage, in /data) ---

storageAdmin:
nodeSelector:
role-datasets-server: "true"
replicas: 1
resources:
requests:
cpu: 4
memory: "4Gi"
limits:
cpu: 4
memory: "4Gi"

# --- reverse proxy ---

reverseProxy:
Expand Down
17 changes: 0 additions & 17 deletions chart/env/staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ images:
useGlobalRegistry: false
repository: datasets-server-services-sse-api
tag: sha-fb3399a
storageAdmin:
registry: huggingface
useGlobalRegistry: false
repository: datasets-server-services-storage-admin
tag: sha-fb3399a
worker:
registry: huggingface
useGlobalRegistry: false
Expand Down Expand Up @@ -184,18 +179,6 @@ queueMetricsCollector:
cpu: 1
memory: "512Mi"

# --- storage admin (to manually inspect the storage, in /data) ---

storageAdmin:
replicas: 1
resources:
requests:
cpu: 50m
memory: "64Mi"
limits:
cpu: 1
memory: "256Mi"

# --- reverse proxy ---

reverseProxy:
Expand Down
9 changes: 0 additions & 9 deletions chart/templates/_common/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ Docker image management
{{ include "hf.common.images.image" (dict "imageRoot" .Values.images.services.sseApi "global" .Values.global.huggingface) }}
{{- end -}}

{{- define "services.storageAdmin.image" -}}
{{ include "hf.common.images.image" (dict "imageRoot" .Values.images.services.storageAdmin "global" .Values.global.huggingface) }}
{{- end -}}

{{- define "services.worker.image" -}}
{{ include "hf.common.images.image" (dict "imageRoot" .Values.images.services.worker "global" .Values.global.huggingface) }}
{{- end -}}
Expand All @@ -79,11 +75,6 @@ Common labels
app.kubernetes.io/component: "{{ include "name" . }}-reverse-proxy"
{{- end -}}

{{- define "labels.storageAdmin" -}}
{{ include "hf.labels.commons" . }}
app.kubernetes.io/component: "{{ include "name" . }}-storage-admin"
{{- end -}}

{{- define "labels.mongodbMigration" -}}
{{ include "hf.labels.commons" . }}
app.kubernetes.io/component: "{{ include "name" . }}-mongodb-migration"
Expand Down
19 changes: 0 additions & 19 deletions chart/templates/storage-admin/_container.tpl

This file was deleted.

26 changes: 0 additions & 26 deletions chart/templates/storage-admin/deployment.yaml

This file was deleted.

20 changes: 0 additions & 20 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,6 @@ images:
useGlobalRegistry: false
repository: datasets-server-services-sse-api
tag: sha-fb3399a
storageAdmin:
registry: huggingface
useGlobalRegistry: false
repository: datasets-server-services-storage-admin
tag: sha-fb3399a
worker:
registry: huggingface
useGlobalRegistry: false
Expand Down Expand Up @@ -374,21 +369,6 @@ cacheMetricsCollector:
cpu: 0
tolerations: []

# --- storage admin (to manually inspect the storage, in /data) ---

storageAdmin:
nodeSelector: {}
replicas: 1
resources:
requests:
cpu: 0
limits:
cpu: 0
service:
type: ""
annotations: {}
tolerations: []

# --- reverse proxy ---

reverseProxy:
Expand Down
11 changes: 0 additions & 11 deletions services/storage-admin/Dockerfile

This file was deleted.

9 changes: 0 additions & 9 deletions services/storage-admin/README.md

This file was deleted.

Loading