Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): search api exposed directly with ALB #2708

Merged
merged 2 commits into from
Apr 12, 2024
Merged

feat(chart): search api exposed directly with ALB #2708

merged 2 commits into from
Apr 12, 2024

Conversation

rtrompier
Copy link
Collaborator

As discussed in #468, let's start to remove nginx proxy.
In this PR, we begin with the search API.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

ArgoCD Diff for commit 6187526

Updated at 4/12/2024, 10:42:55 AM CEST

App: datasets-server-prod
YAML generation: Success 🟢
App sync status: Out of Sync ⚠️

===== apps/Deployment datasets-server/prod-datasets-server-admin ======
--- /tmp/argocd-diff3693967582/prod-datasets-server-admin-live.yaml	2024-04-12 08:42:53.956474150 +0000
+++ /tmp/argocd-diff3693967582/prod-datasets-server-admin	2024-04-12 08:42:53.952474152 +0000
@@ -499,7 +499,7 @@
           value: "9"
         - name: ADMIN_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-admin:sha-d5616b7
+        image: huggingface/datasets-server-services-admin:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-api ======
--- /tmp/argocd-diff4074856862/prod-datasets-server-api-live.yaml	2024-04-12 08:42:53.972474146 +0000
+++ /tmp/argocd-diff4074856862/prod-datasets-server-api	2024-04-12 08:42:53.968474147 +0000
@@ -469,7 +469,7 @@
           value: "9"
         - name: API_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-api:sha-d5616b7
+        image: huggingface/datasets-server-services-api:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-rows ======
--- /tmp/argocd-diff2449429348/prod-datasets-server-rows-live.yaml	2024-04-12 08:42:53.996474139 +0000
+++ /tmp/argocd-diff2449429348/prod-datasets-server-rows	2024-04-12 08:42:53.996474139 +0000
@@ -502,7 +502,7 @@
           value: "8080"
         - name: ROWS_INDEX_MAX_ARROW_DATA_IN_MEMORY
           value: "300_000_000"
-        image: huggingface/datasets-server-services-rows:sha-d5616b7
+        image: huggingface/datasets-server-services-rows:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-search ======
--- /tmp/argocd-diff534871721/prod-datasets-server-search-live.yaml	2024-04-12 08:42:54.020474132 +0000
+++ /tmp/argocd-diff534871721/prod-datasets-server-search	2024-04-12 08:42:54.016474133 +0000
@@ -507,7 +507,7 @@
           value: /tmp/duckdb-extensions
         - name: HF_HUB_ENABLE_HF_TRANSFER
           value: "1"
-        image: huggingface/datasets-server-services-search:sha-d5616b7
+        image: huggingface/datasets-server-services-search:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-sse-api ======
--- /tmp/argocd-diff4249409165/prod-datasets-server-sse-api-live.yaml	2024-04-12 08:42:54.032474129 +0000
+++ /tmp/argocd-diff4249409165/prod-datasets-server-sse-api	2024-04-12 08:42:54.028474130 +0000
@@ -316,7 +316,7 @@
           value: "1"
         - name: API_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-sse-api:sha-d5616b7
+        image: huggingface/datasets-server-services-sse-api:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-storage-admin ======
--- /tmp/argocd-diff2330671189/prod-datasets-server-storage-admin-live.yaml	2024-04-12 08:42:54.040474127 +0000
+++ /tmp/argocd-diff2330671189/prod-datasets-server-storage-admin	2024-04-12 08:42:54.040474127 +0000
@@ -247,7 +247,7 @@
         helm.sh/chart: datasets-server
     spec:
       containers:
-      - image: huggingface/datasets-server-services-storage-admin:sha-d5616b7
+      - image: huggingface/datasets-server-services-storage-admin:sha-43277c4
         imagePullPolicy: IfNotPresent
         name: prod-datasets-server-storage-admin
         resources:

===== apps/Deployment datasets-server/prod-datasets-server-worker-heavy ======
--- /tmp/argocd-diff2903371782/prod-datasets-server-worker-heavy-live.yaml	2024-04-12 08:42:54.064474119 +0000
+++ /tmp/argocd-diff2903371782/prod-datasets-server-worker-heavy	2024-04-12 08:42:54.060474121 +0000
@@ -687,7 +687,7 @@
           value: "1"
         - name: WORKER_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-worker:sha-d5616b7
+        image: huggingface/datasets-server-services-worker:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-worker-light ======
--- /tmp/argocd-diff514204456/prod-datasets-server-worker-light-live.yaml	2024-04-12 08:42:54.092474112 +0000
+++ /tmp/argocd-diff514204456/prod-datasets-server-worker-light	2024-04-12 08:42:54.088474113 +0000
@@ -687,7 +687,7 @@
           value: "1"
         - name: WORKER_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-worker:sha-d5616b7
+        image: huggingface/datasets-server-services-worker:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/prod-datasets-server-worker-medium ======
--- /tmp/argocd-diff106858343/prod-datasets-server-worker-medium-live.yaml	2024-04-12 08:42:54.116474105 +0000
+++ /tmp/argocd-diff106858343/prod-datasets-server-worker-medium	2024-04-12 08:42:54.112474106 +0000
@@ -687,7 +687,7 @@
           value: "1"
         - name: WORKER_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-worker:sha-d5616b7
+        image: huggingface/datasets-server-services-worker:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== batch/CronJob datasets-server/prod-datasets-server-job-backfill ======
--- /tmp/argocd-diff121737602/prod-datasets-server-job-backfill-live.yaml	2024-04-12 08:42:54.140474097 +0000
+++ /tmp/argocd-diff121737602/prod-datasets-server-job-backfill	2024-04-12 08:42:54.140474097 +0000
@@ -255,7 +255,7 @@
               value: backfill
             - name: LOG_LEVEL
               value: debug
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-backfill
             resources:

===== batch/CronJob datasets-server/prod-datasets-server-job-backfill-retryable-errors ======
--- /tmp/argocd-diff1082785685/prod-datasets-server-job-backfill-retryable-errors-live.yaml	2024-04-12 08:42:54.152474094 +0000
+++ /tmp/argocd-diff1082785685/prod-datasets-server-job-backfill-retryable-errors	2024-04-12 08:42:54.148474096 +0000
@@ -256,7 +256,7 @@
               value: backfill-retryable-errors
             - name: LOG_LEVEL
               value: debug
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-backfill-retryable-errors
             resources:

===== batch/CronJob datasets-server/prod-datasets-server-job-cache-metrics-collector ======
--- /tmp/argocd-diff1105293370/prod-datasets-server-job-cache-metrics-collector-live.yaml	2024-04-12 08:42:54.156474093 +0000
+++ /tmp/argocd-diff1105293370/prod-datasets-server-job-cache-metrics-collector	2024-04-12 08:42:54.156474093 +0000
@@ -188,7 +188,7 @@
                   optional: false
             - name: CACHE_MAINTENANCE_ACTION
               value: collect-cache-metrics
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-cache-metrics-collector
             resources:

===== batch/CronJob datasets-server/prod-datasets-server-job-clean-duckdb-cache ======
--- /tmp/argocd-diff3658273578/prod-datasets-server-job-clean-duckdb-cache-live.yaml	2024-04-12 08:42:54.168474090 +0000
+++ /tmp/argocd-diff3658273578/prod-datasets-server-job-clean-duckdb-cache	2024-04-12 08:42:54.164474091 +0000
@@ -246,7 +246,7 @@
               value: cache/*
             - name: DIRECTORY_CLEANING_EXPIRED_TIME_INTERVAL_SECONDS
               value: "259200"
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-clean-duckdb-cache
             resources:

===== batch/CronJob datasets-server/prod-datasets-server-job-clean-duckdb-downloads ======
--- /tmp/argocd-diff3690673273/prod-datasets-server-job-clean-duckdb-downloads-live.yaml	2024-04-12 08:42:54.180474086 +0000
+++ /tmp/argocd-diff3690673273/prod-datasets-server-job-clean-duckdb-downloads	2024-04-12 08:42:54.180474086 +0000
@@ -246,7 +246,7 @@
               value: downloads/*
             - name: DIRECTORY_CLEANING_EXPIRED_TIME_INTERVAL_SECONDS
               value: "259200"
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-clean-duckdb-downloads
             resources:

===== batch/CronJob datasets-server/prod-datasets-server-job-post-messages ======
--- /tmp/argocd-diff116529081/prod-datasets-server-job-post-messages-live.yaml	2024-04-12 08:42:54.188474084 +0000
+++ /tmp/argocd-diff116529081/prod-datasets-server-job-post-messages	2024-04-12 08:42:54.188474084 +0000
@@ -211,7 +211,7 @@
               value: post-messages
             - name: LOG_LEVEL
               value: info
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-post-messages
             resources:

===== batch/CronJob datasets-server/prod-datasets-server-job-queue-metrics-collector ======
--- /tmp/argocd-diff3003076649/prod-datasets-server-job-queue-metrics-collector-live.yaml	2024-04-12 08:42:54.196474081 +0000
+++ /tmp/argocd-diff3003076649/prod-datasets-server-job-queue-metrics-collector	2024-04-12 08:42:54.196474081 +0000
@@ -188,7 +188,7 @@
                   optional: false
             - name: CACHE_MAINTENANCE_ACTION
               value: collect-queue-metrics
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: prod-datasets-server-queue-metrics-collector
             resources:

===== networking.k8s.io/Ingress datasets-server/prod-datasets-server-search ======
--- /tmp/argocd-diff2876926977/prod-datasets-server-search-live.yaml	2024-04-12 08:42:54.220474075 +0000
+++ /tmp/argocd-diff2876926977/prod-datasets-server-search	2024-04-12 08:42:54.220474075 +0000
@@ -0,0 +1,37 @@
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  annotations:
+    alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:us-east-1:707930574880:certificate/971187a3-2baa-40e5-bcae-94d6ec55cd24
+    alb.ingress.kubernetes.io/group.name: datasets-server
+    alb.ingress.kubernetes.io/healthcheck-path: /healthcheck
+    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80, "HTTPS": 443}]'
+    alb.ingress.kubernetes.io/load-balancer-name: hub-datasets-server-prod
+    alb.ingress.kubernetes.io/scheme: internet-facing
+    alb.ingress.kubernetes.io/tags: Env=prod,Project=datasets-server,Terraform=true
+    alb.ingress.kubernetes.io/target-node-labels: role-datasets-server=true
+    kubernetes.io/ingress.class: alb
+  labels:
+    app.kubernetes.io/component: prod-datasets-server-search
+    app.kubernetes.io/instance: prod
+    app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: prod-datasets-server
+    argocd.argoproj.io/instance: datasets-server-prod
+    helm.sh/chart: datasets-server
+  name: prod-datasets-server-search
+  namespace: datasets-server
+spec:
+  rules:
+  - host: datasets-server.huggingface.co
+    http:
+      paths:
+      - backend:
+          service:
+            name: prod-datasets-server-search
+            port:
+              name: http
+        path: /search
+        pathType: Prefix
+  tls:
+  - hosts:
+    - datasets-server.huggingface.co

App: datasets-server-staging
YAML generation: Success 🟢
App sync status: Out of Sync ⚠️

===== apps/Deployment datasets-server/staging-datasets-server-admin ======
--- /tmp/argocd-diff947203832/staging-datasets-server-admin-live.yaml	2024-04-12 08:42:55.148473809 +0000
+++ /tmp/argocd-diff947203832/staging-datasets-server-admin	2024-04-12 08:42:55.144473810 +0000
@@ -491,7 +491,7 @@
           value: "1"
         - name: ADMIN_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-admin:sha-d5616b7
+        image: huggingface/datasets-server-services-admin:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/staging-datasets-server-api ======
--- /tmp/argocd-diff783229484/staging-datasets-server-api-live.yaml	2024-04-12 08:42:55.168473803 +0000
+++ /tmp/argocd-diff783229484/staging-datasets-server-api	2024-04-12 08:42:55.164473804 +0000
@@ -453,7 +453,7 @@
           value: "1"
         - name: API_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-api:sha-d5616b7
+        image: huggingface/datasets-server-services-api:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/staging-datasets-server-rows ======
--- /tmp/argocd-diff785430509/staging-datasets-server-rows-live.yaml	2024-04-12 08:42:55.192473796 +0000
+++ /tmp/argocd-diff785430509/staging-datasets-server-rows	2024-04-12 08:42:55.188473797 +0000
@@ -507,7 +507,7 @@
           value: "8080"
         - name: ROWS_INDEX_MAX_ARROW_DATA_IN_MEMORY
           value: "300_000_000"
-        image: huggingface/datasets-server-services-rows:sha-d5616b7
+        image: huggingface/datasets-server-services-rows:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/staging-datasets-server-search ======
--- /tmp/argocd-diff4255753661/staging-datasets-server-search-live.yaml	2024-04-12 08:42:55.212473790 +0000
+++ /tmp/argocd-diff4255753661/staging-datasets-server-search	2024-04-12 08:42:55.208473791 +0000
@@ -512,7 +512,7 @@
           value: /tmp/duckdb-extensions
         - name: HF_HUB_ENABLE_HF_TRANSFER
           value: "1"
-        image: huggingface/datasets-server-services-search:sha-d5616b7
+        image: huggingface/datasets-server-services-search:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/staging-datasets-server-sse-api ======
--- /tmp/argocd-diff3403667443/staging-datasets-server-sse-api-live.yaml	2024-04-12 08:42:55.224473786 +0000
+++ /tmp/argocd-diff3403667443/staging-datasets-server-sse-api	2024-04-12 08:42:55.220473787 +0000
@@ -319,7 +319,7 @@
           value: "1"
         - name: API_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-sse-api:sha-d5616b7
+        image: huggingface/datasets-server-services-sse-api:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/staging-datasets-server-storage-admin ======
--- /tmp/argocd-diff2956583716/staging-datasets-server-storage-admin-live.yaml	2024-04-12 08:42:55.232473784 +0000
+++ /tmp/argocd-diff2956583716/staging-datasets-server-storage-admin	2024-04-12 08:42:55.232473784 +0000
@@ -246,7 +246,7 @@
         helm.sh/chart: datasets-server
     spec:
       containers:
-      - image: huggingface/datasets-server-services-storage-admin:sha-d5616b7
+      - image: huggingface/datasets-server-services-storage-admin:sha-43277c4
         imagePullPolicy: IfNotPresent
         name: staging-datasets-server-storage-admin
         resources:

===== apps/Deployment datasets-server/staging-datasets-server-worker-all ======
--- /tmp/argocd-diff845368916/staging-datasets-server-worker-all-live.yaml	2024-04-12 08:42:55.260473775 +0000
+++ /tmp/argocd-diff845368916/staging-datasets-server-worker-all	2024-04-12 08:42:55.256473777 +0000
@@ -694,7 +694,7 @@
           value: "1"
         - name: WORKER_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-worker:sha-d5616b7
+        image: huggingface/datasets-server-services-worker:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== apps/Deployment datasets-server/staging-datasets-server-worker-light ======
--- /tmp/argocd-diff1823904354/staging-datasets-server-worker-light-live.yaml	2024-04-12 08:42:55.288473768 +0000
+++ /tmp/argocd-diff1823904354/staging-datasets-server-worker-light	2024-04-12 08:42:55.280473769 +0000
@@ -694,7 +694,7 @@
           value: "1"
         - name: WORKER_UVICORN_PORT
           value: "8080"
-        image: huggingface/datasets-server-services-worker:sha-d5616b7
+        image: huggingface/datasets-server-services-worker:sha-43277c4
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 30

===== batch/CronJob datasets-server/staging-datasets-server-job-cache-metrics-collector ======
--- /tmp/argocd-diff3250837955/staging-datasets-server-job-cache-metrics-collector-live.yaml	2024-04-12 08:42:55.304473763 +0000
+++ /tmp/argocd-diff3250837955/staging-datasets-server-job-cache-metrics-collector	2024-04-12 08:42:55.300473764 +0000
@@ -186,7 +186,7 @@
                   optional: false
             - name: CACHE_MAINTENANCE_ACTION
               value: collect-cache-metrics
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: staging-datasets-server-cache-metrics-collector
             resources:

===== batch/CronJob datasets-server/staging-datasets-server-job-clean-duckdb-cache ======
--- /tmp/argocd-diff3424873615/staging-datasets-server-job-clean-duckdb-cache-live.yaml	2024-04-12 08:42:55.312473760 +0000
+++ /tmp/argocd-diff3424873615/staging-datasets-server-job-clean-duckdb-cache	2024-04-12 08:42:55.312473760 +0000
@@ -245,7 +245,7 @@
               value: cache/*
             - name: DIRECTORY_CLEANING_EXPIRED_TIME_INTERVAL_SECONDS
               value: "600"
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: staging-datasets-server-clean-duckdb-cache
             resources:

===== batch/CronJob datasets-server/staging-datasets-server-job-clean-duckdb-downloads ======
--- /tmp/argocd-diff2606641055/staging-datasets-server-job-clean-duckdb-downloads-live.yaml	2024-04-12 08:42:55.324473757 +0000
+++ /tmp/argocd-diff2606641055/staging-datasets-server-job-clean-duckdb-downloads	2024-04-12 08:42:55.324473757 +0000
@@ -245,7 +245,7 @@
               value: downloads/*
             - name: DIRECTORY_CLEANING_EXPIRED_TIME_INTERVAL_SECONDS
               value: "600"
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: staging-datasets-server-clean-duckdb-downloads
             resources:

===== batch/CronJob datasets-server/staging-datasets-server-job-post-messages ======
--- /tmp/argocd-diff3909786592/staging-datasets-server-job-post-messages-live.yaml	2024-04-12 08:42:55.332473754 +0000
+++ /tmp/argocd-diff3909786592/staging-datasets-server-job-post-messages	2024-04-12 08:42:55.332473754 +0000
@@ -210,7 +210,7 @@
               value: post-messages
             - name: LOG_LEVEL
               value: info
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: staging-datasets-server-post-messages
             resources:

===== batch/CronJob datasets-server/staging-datasets-server-job-queue-metrics-collector ======
--- /tmp/argocd-diff3395493583/staging-datasets-server-job-queue-metrics-collector-live.yaml	2024-04-12 08:42:55.340473753 +0000
+++ /tmp/argocd-diff3395493583/staging-datasets-server-job-queue-metrics-collector	2024-04-12 08:42:55.340473753 +0000
@@ -187,7 +187,7 @@
                   optional: false
             - name: CACHE_MAINTENANCE_ACTION
               value: collect-queue-metrics
-            image: huggingface/datasets-server-jobs-cache_maintenance:sha-d5616b7
+            image: huggingface/datasets-server-jobs-cache_maintenance:sha-43277c4
             imagePullPolicy: IfNotPresent
             name: staging-datasets-server-queue-metrics-collector
             resources:

===== networking.k8s.io/Ingress datasets-server/staging-datasets-server-search ======
--- /tmp/argocd-diff3662907480/staging-datasets-server-search-live.yaml	2024-04-12 08:42:55.360473747 +0000
+++ /tmp/argocd-diff3662907480/staging-datasets-server-search	2024-04-12 08:42:55.360473747 +0000
@@ -0,0 +1,35 @@
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  annotations:
+    alb.ingress.kubernetes.io/group.name: datasets-server
+    alb.ingress.kubernetes.io/healthcheck-path: /healthcheck
+    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80, "HTTPS": 443}]'
+    alb.ingress.kubernetes.io/load-balancer-name: hub-datasets-server-staging
+    alb.ingress.kubernetes.io/scheme: internet-facing
+    alb.ingress.kubernetes.io/tags: Env=staging,Project=datasets-server,Terraform=true
+    kubernetes.io/ingress.class: alb
+  labels:
+    app.kubernetes.io/component: staging-datasets-server-search
+    app.kubernetes.io/instance: staging
+    app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: staging-datasets-server
+    argocd.argoproj.io/instance: datasets-server-staging
+    helm.sh/chart: datasets-server
+  name: staging-datasets-server-search
+  namespace: datasets-server
+spec:
+  rules:
+  - host: datasets-server.us.dev.moon.huggingface.tech
+    http:
+      paths:
+      - backend:
+          service:
+            name: staging-datasets-server-search
+            port:
+              name: http
+        path: /search
+        pathType: Prefix
+  tls:
+  - hosts:
+    - datasets-server.us.dev.moon.huggingface.tech
Legend Status
✅ The app is synced in ArgoCD, and diffs you see are solely from this PR.
⚠️ The app is out-of-sync in ArgoCD, and the diffs you see include those changes plus any from this PR.
🛑 There was an error generating the ArgoCD diffs due to changes in this PR.

severo
severo reviewed Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

I don't know much about k8s ingress, so... I cannot really review the ingress.yaml file.

But what is sure is that we have to include some type of conditional in the nginx template, because we rely on it in the e2e tests.

Another way might be to have a specific nginx template just for the e2e tests.

What do you think?

@rtrompier
Copy link
Collaborator Author

Ok, so let's keep the proxy for now.
It will be bypassed by the ALB once deployed.

@rtrompier rtrompier merged commit 48f893d into main Apr 12, 2024
2 checks passed
@rtrompier rtrompier deleted the feat/search-ingress-alb branch April 12, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severo severo severo approved these changes

@AndreaFrancis AndreaFrancis Awaiting requested review from AndreaFrancis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtrompier @severo