Factorize getting required request parameters #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
+ Coverage 85.44% 86.53% +1.08%
==========================================
Files 23 67 +44
Lines 907 3497 +2590
==========================================
+ Hits 775 3026 +2251
- Misses 132 471 +339
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
The documentation is not available anymore as the PR was closed or merged. |
AndreaFrancis
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Extract function get_request_parameter_dataset * Move get_request_parameter_dataset to libapi * Factorize get_request_parameter_config * Factorize get_request_parameter_split * Factorize get_required_request_parameter * Use get_required_request_parameter for query/where * Remove redundant error messages * Update openapi.json * Test get_required_request_parameter
AndreaFrancis
added a commit
that referenced
this pull request
Oct 12, 2023
* clean duckdb index files * refactor to use only one function for cleaning * minor fixes * Apply suggestions from code review Co-authored-by: Sylvain Lesage <[email protected]> * Factorize getting required request parameters (#1965) * Extract function get_request_parameter_dataset * Move get_request_parameter_dataset to libapi * Factorize get_request_parameter_config * Factorize get_request_parameter_split * Factorize get_required_request_parameter * Use get_required_request_parameter for query/where * Remove redundant error messages * Update openapi.json * Test get_required_request_parameter * Remove duplicate admin utils (#1970) * Delete duplicate admin get_json_ok_response * Use libapi get_json_api_error_response in admin * Delete duplicate admin EXPOSED_HEADERS * Remove duplicate admin Endpoint * Remove duplicate admin are_valid_parameters * Remove unused admin utils * refactor directory env for cleaning * minor changes * fix style --------- Co-authored-by: Sylvain Lesage <[email protected]> Co-authored-by: Albert Villanova del Moral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorize getting the required request parameters
dataset,config,split,queryandwhere(from the service admin and the endpoints /rows, /search and /filter) tolibapi.Additionally, align their error messages.