Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align starlette to 0.28.0 in all subpackages #1945

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Conversation

albertvillanova
Copy link
Member

This PR aligns the starlette version to 0.28.0 in all subpackages.

Note that before this PR:

  • in the admin and worker services, starlette was pinned to 0.27.0
  • whereas in the libapi, starlette was pinned to 0.28.0

Thus, the admin and worker services could not use the libapi (subsequent PR).

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (41ea211) 95.56% compared to head (4c1c87e) 89.25%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
- Coverage   95.56%   89.25%   -6.32%     
==========================================
  Files          14      154     +140     
  Lines         519     8755    +8236     
==========================================
+ Hits          496     7814    +7318     
- Misses         23      941     +918     
Flag Coverage Δ
jobs_cache_maintenance 95.56% <ø> (ø)
jobs_mongodb_migration 86.32% <ø> (?)
libs_libcommon 92.08% <ø> (?)
services_admin 85.59% <ø> (?)
services_api 86.79% <ø> (?)
services_rows 84.06% <ø> (?)
services_search 77.46% <50.00%> (?)
services_sse-api 94.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/search/tests/routes/test_filter.py 100.00% <100.00%> (ø)
services/search/src/search/routes/filter.py 46.06% <0.00%> (ø)

... and 138 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertvillanova albertvillanova merged commit a0ef4cd into main Oct 9, 2023
19 of 20 checks passed
@albertvillanova albertvillanova deleted the align-starlette branch October 9, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants