Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libapi duckdb dependency in all services #1943

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Oct 6, 2023

Now that libapi depends on duckdb, this PR updates libapi in all services.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6c5e7ef) 86.69% compared to head (752b977) 87.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
+ Coverage   86.69%   87.61%   +0.92%     
==========================================
  Files         128       24     -104     
  Lines        5282     1478    -3804     
==========================================
- Hits         4579     1295    -3284     
+ Misses        703      183     -520     
Flag Coverage Δ
jobs_cache_maintenance ?
jobs_mongodb_migration ?
libs_libapi ?
services_admin ?
services_api 86.79% <ø> (ø)
services_rows 84.06% <ø> (ø)
services_search ?
services_sse-api 94.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 104 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@severo
Copy link
Collaborator

severo commented Oct 6, 2023

just for curiosity: are we sure that all the services (and libapi) use the last version of libcommon as well?

@albertvillanova
Copy link
Member Author

@severo that was done in PR:

See commit: eca2358

@albertvillanova albertvillanova merged commit 0f8e0a2 into main Oct 9, 2023
7 of 8 checks passed
@albertvillanova albertvillanova deleted the update-libapi branch October 9, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants