fix(chart): block admin metrics exposition

huggingface · Sep 13, 2024 · acb51c4 · acb51c4
1 parent d6edf09
commit acb51c4
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/chart/templates/services/admin/ingress.yaml b/chart/templates/services/admin/ingress.yaml
@@ -12,6 +12,13 @@ spec:
     - host: {{ include "datasetsServer.ingress.hostname" . }}
       http:
         paths:
+          - path: /admin
+            pathType: Prefix
+            backend:
+              service:
+                name: "{{ include "name" . }}-admin"
+                port:
+                  name: http
           {{- if hasKey $annotations "alb.ingress.kubernetes.io/actions.metrics-unauthorized" }}
           - path: /admin/metrics
             pathType: Exact
@@ -20,13 +27,6 @@ spec:
                 name: metrics-unauthorized
                 port:
                   name: use-annotation
-          {{ end -}}
-          - path: /admin
-            pathType: Prefix
-            backend:
-              service:
-                name: "{{ include "name" . }}-admin"
-                port:
-                  name: http
+          {{- end -}}
 {{- include "ingress.tls" (merge (dict "annotations" $annotations) $ ) | indent 2}}
 {{- end }}