Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the README #1363

Closed
wants to merge 3 commits into from
Closed

Conversation

EricLBuehler
Copy link
Member

I reduced the README source line count by 61% (currently is 39% of original line count!). This reduction was accomplished without deletion of material from the repository. When applicable, I moved the following sections from the README to the Book:

  • Large images
  • Technical guides
  • Code blocks
  • Common errors

Additionally, I condensed the features section to show only the "big ideas" and avoid listing all the models. The original section has also been moved to the Book.

Please see my fork of Candle for comparison.

I have 2 questions:

  1. Do you think the lack of images and the GIF is okay? (There is still a link to the full page with images and the how-to-run guide)
  2. Do you think this is an effective change that will reduce verbosity?

@LaurentMazare
Copy link
Collaborator

LaurentMazare commented Nov 24, 2023

The readme was including this material on purpose, if you want to write different/better teaching material on candle that's very welcome and useful but please do so in some external repo/blog/...

@EricLBuehler
Copy link
Member Author

Ok, sure. Just wanted to see if this could help. Thanks!

@EricLBuehler EricLBuehler deleted the readme branch March 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants