PyO3: Better shape handling #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, i renamed it to |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to provide shapes as
*argsmeaning thatrand((10,10))can now also be written asrand(10,10). I also added a newPyRelativeShapestruct which handles negative dims, e.g.t.reshape(-1,1). I decided to add this new struct to explicitly make some functions accept "relative" shapes (e.g.reshape) and force other functions to only accept normalPyShapes(e.g.rand).I also needed to upgrade
pyo3from0.19.0to0.20.0as there was a bug with*argsand named parameters which got fixed in0.20.0e.g.rand(*shape, device=None)wouldn't let me specify a device even if the python code was valid.