[FSDP][Example] Fix FSDP example for use_orig_params=False
#3298
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the FSDP example for
use_orig_params=False
. I recently started using FSDP via Accelerate and hit some roadblocks due to rough edges in documentation and examples. Some improvements in this PR:use_orig_params=False
should be the recommended route all the time (full param/ lora), since it's typically more efficient.use_orig_params=False
requires model preparation before optimizer instantiation. This is a silent failure - I noticed that loss didn't decrease in this case. I believe it is best if.prepare
has extra validation for this and raise an Error to the user. (Might do this in a separate PR if I get time). The example prepares everything together because it assumesuse_orig_params
is True from this PR: fsdp refactoring #2177use_orig_params
. I found a note from an older version so I brought it back.SHARD_GRAD_OP
is a bit different from Zero Stage 2, this PR adds a tiny note.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @muellerzr