-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allocate 80% for cpu is unset in max_memory
#2219
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M, slight nit on the docstring
Co-authored-by: Zach Mueller <[email protected]>
Co-authored-by: Zach Mueller <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do ?
This PR modifies
max_memory
by allocating 80% of cpu memory of "cpu" is not passed inmax_memory
. The idea was in case the user did not specify the cpu allocation usingmax_memory
arg, we should just infer from the current system available memory minus some reserved pool for the OS to continue to work. Otherwise, we will move directly to disk offload.cc @mfuntowicz as you suggested.
Before this PR:
After this PR
TODO: