Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check notebook launcher for 3090+ #2212

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Check notebook launcher for 3090+ #2212

merged 8 commits into from
Dec 5, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Similar to prior work done in #2195, I noticed when using the notebook_launcher this would need to be done here as well. Rather than having the user manually set these values themselves, modifies the check to include a torch-save version of checking GPU names (by just calling nvidia-smi under the hood).

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan @SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding on this issue.

modifies the check to include a torch-save version of checking GPU names (by just calling nvidia-smi under the hood)

Could you explain this a bit more? At first glance, the old method looks more robust.

src/accelerate/state.py Show resolved Hide resolved
src/accelerate/utils/environment.py Show resolved Hide resolved
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR. I had some issues running the new code on my machine, please check the comments.

src/accelerate/utils/environment.py Show resolved Hide resolved
src/accelerate/utils/environment.py Outdated Show resolved Hide resolved
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this !

@muellerzr muellerzr merged commit 8f871f4 into main Dec 5, 2023
25 checks passed
@muellerzr muellerzr deleted the check-notebook-launcher branch December 5, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants