Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for problematic libraries #2151

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Add warning for problematic libraries #2151

merged 5 commits into from
Nov 17, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Since this is a very common issue, adds a check in notebook_launcher for specific libraries that are known to cause issues (such as starting CUDA forks on import).

Fixes #2148

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan @SunMarc

Comment on lines -69 to -70
# Need to see why this test raises forking issues when ran as a suite
@skip
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially the notebook_launcher doesn't like using async subprocesses when doing things, so executing it fully as a non-async subprocess makes this fully work reliably.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 14, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to make this an explicit error, given how many users stumble upon this. I only have some smaller comments.

src/accelerate/launchers.py Outdated Show resolved Hide resolved
src/accelerate/utils/environment.py Outdated Show resolved Hide resolved
src/accelerate/utils/environment.py Outdated Show resolved Hide resolved
src/accelerate/launchers.py Outdated Show resolved Hide resolved
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the points I raised. I only have a small comment about a type annotation, feel free to merge.

src/accelerate/utils/environment.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit cd51581 into main Nov 17, 2023
25 checks passed
@muellerzr muellerzr deleted the bnb-nb-launcher branch November 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notebook_launcher fails when loading model from_pretrained
3 participants