-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify config file path on README #2140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, just needs some tweaks. Let's change this to have accelerate config
explicitly save it to a location if we want to do so. Otherwise the latter command should be modified to show where the config coming from. These commands need to be ran quickly via copy/paste for new users. So let's go with my suggestion here and propagate it below :)
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Good suggestion. I applied your suggestion to all proper positions. Though it is minor issue, I'm not sure what form of the second command you wanted to be. But it already has |
@kwonmha the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I had hard time figuring out how to run on multi-node configuration with the given instructions.
It looked like no configuration file argument is required and accelerate will find the generated configuration automatically.
Just few more phrases are needed.
@muellerzr , @pacman100