Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stalebot #2052

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix stalebot #2052

merged 1 commit into from
Oct 13, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Fixes broken stalebot (ref: huggingface/peft#1016)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan @LysandreJik

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

BenjaminBossan
BenjaminBossan approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEFT stalebot got back to work, so this should be good too.

Loved this time indication when I checked:

image

@muellerzr muellerzr merged commit caa9f9b into main Oct 13, 2023
4 checks passed
@muellerzr muellerzr deleted the stalebot branch October 13, 2023 16:20
@younesbelkada younesbelkada mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @BenjaminBossan