Better guards for slow imports #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
commented
Sep 12, 2023
Comment on lines
-183
to
-187
| if is_tensorboard_available(): | ||
| try: | ||
| from torch.utils import tensorboard | ||
| except ModuleNotFoundError: | ||
| import tensorboardX as tensorboard |
There was a problem hiding this comment.
This will be called to assume tensorboard is available, and if it's not we should raise the import error in the case of a user is trying to pass their own TensorBoardTracker instance to the Accelerator
|
The documentation is not available anymore as the PR was closed or merged. |
SunMarc
approved these changes
Sep 12, 2023
BenjaminBossan
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR guards slower imports better, namely the trackers and especially
deepspeedacross the framework.Alternative to #1961, unless we decide that it's getting too repetitive and we want a wrapper
Fixes # (issue)
Resolves #1952
Speedup
Before, with DeepSpeed installed too:
After:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @BenjaminBossan