Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples within the docs/ #88

Merged
merged 37 commits into from
Sep 21, 2024
Merged

Add examples within the docs/ #88

merged 37 commits into from
Sep 21, 2024

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Sep 12, 2024

Description

This PR adds the examples to the https://hf.co/docs/google-cloud documentation, so as to add more content there.

@alvarobartt alvarobartt added the documentation Improvements or additions to documentation label Sep 12, 2024
@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@alvarobartt alvarobartt changed the title Add examples within the docs/ [WIP] Add examples within the docs/ Sep 12, 2024
@alvarobartt alvarobartt linked an issue Sep 16, 2024 that may be closed by this pull request
@alvarobartt alvarobartt self-assigned this Sep 17, 2024
@alvarobartt alvarobartt changed the title [WIP] Add examples within the docs/ Add examples within the docs/ Sep 18, 2024
- [Serve Gemma open models using GPUs on GKE with Hugging Face TGI](https://cloud.google.com/kubernetes-engine/docs/tutorials/serve-gemma-gpu-tgi)
- [Generative AI on Vertex - Use Hugging Face text generation models](https://cloud.google.com/vertex-ai/generative-ai/docs/open-models/use-hugging-face-models)

## Examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this part now it's available on the left side navigation bar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep it, if it is automatic updated.

Copy link
Collaborator

@pagezyhf pagezyhf Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should remove even if automatically updated:

  • We have too many links on this page which impacts bounce rate (so far 1 out of 500 exit page are one of those links, and its a blogpost, not an example)
  • It's the same as what we have on the left side navigation menu

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your other argument on SEO @philschmid, you know better than me what works and what not. I would have thought that the separated page for each example is what you want to be at the top of Google results rather than the docs/source/resources.mdx page.

docs/source/resources.mdx Outdated Show resolved Hide resolved
docs/source/resources.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@pagezyhf pagezyhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great!
2 feedbacks:

  • Would be good to define standards in example names for easier discoverability
  • I think we could separate better how to deploy from the Hub, from the Model Garden in GCP and from a notebook. I don't want to mix this in this PR, so i'll make a suggestion once this PR is merged.

@philschmid
Copy link
Member

that's great! 2 feedbacks:

  • Would be good to define standards in example names for easier discoverability
  • I think we could separate better how to deploy from the Hub, from the Model Garden in GCP and from a notebook. I don't want to mix this in this PR, so i'll make a suggestion once this PR is merged.

I would keep it if automated. As it might be better for SEO. Its always good to have a full overview.

@alvarobartt
Copy link
Member Author

Thank you for the review @philschmid and @pagezyhf!

So for the examples and containers listing I want to start moving some scripts I use locally into a separate GitHub Action so that those are automatically generated yes. In this case, for the "additional" example listing I think we can keep it, but I don't know much about best SEO practices either.

Copy link
Member

@jeffboudier jeffboudier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great improvements! I like the new example navigation structure. I think we can keep the list of examples duplicated in the "more resources" page.

docs/source/resources.mdx Outdated Show resolved Hide resolved
@alvarobartt alvarobartt merged commit 241791c into main Sep 21, 2024
2 checks passed
@alvarobartt alvarobartt deleted the add-notebooks-to-docs branch September 21, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Add documentation to be hosted in hf.co/docs
5 participants