Add missing google-cloud-storage dependency in PyTorch DLC
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
changed the title
transformers 4.41.0)google-cloud-storage dependency in PyTorch DLC
philschmid
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up of #120 as reported by @xuyifann due to a missing dependency for
google-cloud-storagewithin the Hugging Face PyTorch DLC for Inference on both CPU and GPU for thetransformersversion 4.41.0; as when patching the DLC in #120, that dependency was missing, but was catched during the testing after building the DLC.This PR then adds the missing
google-cloud-storagedependency within the Dockerfile, to patch that exact DLC, whilst the rest work fine, since those dependencies are installed as part of thegoogleextra ofhuggingface-inference-toolkit, not available within the pinnedhuggingface-inference-toolkitversion installed in this DLC in particular.