Docker support #72
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| FROM alpine:latest AS builder | ||
|
|
||
| RUN apk update && apk add --no-cache \ | ||
| git \ | ||
| build-base \ | ||
| openssl-dev \ | ||
| libpcap-dev \ | ||
| linux-headers \ | ||
| musl-dev | ||
|
|
||
| RUN git clone https://github.com/hufrea/byedpi /opt/byedpi | ||
|
There was a problem hiding this comment. There is no need for cloning the repo, because we already have it with Dockerfile. So, There was a problem hiding this comment.
Sometimes users just downloads one Dockerfile at all, instead of full repo. I think Dockerfile can be self-contained, no need to download all repository code to operating systems that don't have git installed, you might not even have a compiler on the host There was a problem hiding this comment. Anyway, fetching specified version always better than fetching latest master There was a problem hiding this comment.
Great advice, thanks! Fixed to latest release code. |
||
|
|
||
| WORKDIR /opt/byedpi | ||
|
|
||
| RUN make | ||
|
|
||
| FROM alpine:latest | ||
|
|
||
| COPY --from=builder /opt /opt | ||
|
|
||
| EXPOSE 1080 | ||
|
|
||
| ENTRYPOINT ["/opt/byedpi/ciadpi"] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, Removed unnecessary dependencies
build-base + linux headers = build tools + linux/tcp.h
curl + git = getting latest github release code from releases only, not master