Add code checks to hubverse-infrastructure #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ruff, a corresponding config file, and the formatting changes that it suggested
Note that mypy doesn't play especially well with pulumi. Problematic lines are ignored so the type checker will pass.
This is the first iteration of code check workflow for the hubverse-infrastructure repo. It's obviously missing a job step to run tests, which is a future piece of "getting ready for production" work.
Adding a pre-commit config that mirrors the new "code check" GitHub action. This is optional, but can be used by devs who have pre-commit as part of their workflow. https://pre-commit.com/
🍹
|
elray1
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves hubverse-org/hubverse-cloud#66
This PR adds the mypy and ruff Python libraries for type-checking and linting. Additionally, there is a new GitHub workflow that runs these checks.
Most of the other changes fix issues that the linter flagged the first time it was run.
Reviewing this by stepping through each commit will show the separate work for each type of code check.
Edited to add: to pulumi preview comment is a bit awkward to follow. Essentially, you can click on pulumi report and scroll to the bottom to see what infrastructure components (if any) would be changed by the PR.
In this case, the PR doesn't impact any infrastructure: