plugin-flow-builder: replace bot action id for payload with params in pre funtion #BLT1187 #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
requested review from
asastre and
vanbasten17
and removed request for
asastre
Iru89
requested review from
asastre and
vanbasten17
and removed request for
vanbasten17
Iru89
force-pushed
the
BLT-1187-click-on-button-that-targets-bot-action-we-dont-have-to-use-redirect
branch
from
66bcc0e
to
bb90422
Compare
asastre
approved these changes
Nov 4, 2024
Comment on lines
113
to
+123
| if (request.input.payload) { | ||
| request.input.payload = this.removeSourceSufix(request.input.payload) | ||
| } | ||
|
|
||
| if (request.input.payload && this.isBotAction(request.input.payload)) { | ||
| const cmsBotAction = this.cmsApi.getNodeById<HtBotActionNode>( | ||
| request.input.payload | ||
| ) | ||
|
|
||
| request.input.payload = this.cmsApi.createPayloadWithParams(cmsBotAction) | ||
| } |
There was a problem hiding this comment.
Suggestion: You can unify both if (request.input.payload) conditions
vanbasten17
approved these changes
Nov 5, 2024
Iru89
changed the title
Iru89
changed the title
Iru89
deleted the
BLT-1187-click-on-button-that-targets-bot-action-we-dont-have-to-use-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-apply the old logic for buttons pointing to bot action nodes.
When the user clicks on a button pointing to a bot action, the bot receives in the payload the id of the bot action node. In the plugin's pre function it checks if the id is from a bot action node and if so it replaces the payload with the payload with the parameters defined in the bot action node. This way, when reaching the bot routes, the payload is already the expected one and it is not necessary to make a redirect to run the core-bot again.
Testing
Update test to check that the payload after pre function is the payload with params defined in bot action node