Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix error fetching more bots #2925

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Oct 10, 2024

Description

Add await when call getMoreBots
Remove duplicated call to getBots inside deployBotFromFlag function
Add generic type T to apiGet function

@Iru89 Iru89 changed the title Cli fix error fetching more bots cli: fix error fetching more bots Oct 10, 2024
Copy link
Contributor

@asastre asastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 2 questions/suggestions before approving

packages/botonic-cli/src/botonic-api-service.ts Outdated Show resolved Hide resolved
packages/botonic-cli/src/botonic-api-service.ts Outdated Show resolved Hide resolved
@Iru89 Iru89 force-pushed the cli-fix-error-fetching-more-bots branch from ac42103 to 50e2d7a Compare October 10, 2024 14:49
Copy link

github-actions bot commented Oct 10, 2024

Test Results

30 tests   30 ✅  4m 29s ⏱️
 6 suites   0 💤
 1 files     0 ❌

Results for commit 6124b37.

♻️ This comment has been updated with latest results.

@vanbasten17 vanbasten17 merged commit 5245e67 into master-lts Oct 29, 2024
4 of 5 checks passed
@vanbasten17 vanbasten17 deleted the cli-fix-error-fetching-more-bots branch October 29, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants