Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding docs improvements #892

Merged
merged 15 commits into from
Jan 16, 2025
Merged

Embedding docs improvements #892

merged 15 commits into from
Jan 16, 2025

Conversation

axdanbol
Copy link
Contributor

@axdanbol axdanbol commented Jan 9, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 5a4b296.

Command Status Duration Result
nx affected --targets=build-storybook --configu... ✅ Succeeded 1s View ↗
nx affected --targets=compodoc --configuration=ci ✅ Succeeded 5s View ↗
nx affected --targets=build-webcomponent --conf... ✅ Succeeded 2s View ↗
nx affected --targets=build --configuration=pre... ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 18:36:36 UTC

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

axdanbol added 14 commits January 9, 2025 16:35
@axdanbol
docs(app:ftu-ui): 📝 Tweaked a couple of code snippets for style consi…
e85d27d 
…stency
@axdanbol
docs(app:ftu-ui): 📝 Removed some incorrect information + minor tweaks
5604dd8
@axdanbol
docs(app:ftu-ui): 📝 Remove section that was simply repeating previous…
514974c 
… information
@axdanbol
docs(app:ftu-ui): 📝 Add embedding docs for ftu-ui-small-wc
01c9eb6
@axdanbol
docs(app:medical-illustration): 📝 Add embedding docs for medical illu…
4a5b0ae 
…stration
@axdanbol
docs(app:node-dist-vis): 📝 Add embedding docs
f610845
@axdanbol
refactor(app:ccf-rui): Remove unused inputs and config from rui
76e20eb
@axdanbol
docs(app:ccf-rui): 📝 Add embedding instructions for rui
16378ef
@axdanbol
docs(app:ccf-eui): 📝 Add embedding docs for eui
f7f09cc
@axdanbol
docs(global): 📝 Update the global embedding docs
8d97343
@axdanbol
feat(lib:design-system): ✨ Add back bar component
eceec94
@axdanbol
test(lib:ccf-shared): ✅ Fix test
ff9ce7d
@axdanbol
docs(lib:design-system): 📝 Increase code docs for back bar component
10fbd1a
@axdanbol
feat(app:ccf-rui): Display a back bar when cancel registration is set…
5a4b296 
…, i.e. embedded mode
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@axdanbol axdanbol marked this pull request as ready for review January 15, 2025 18:40
@axdanbol axdanbol requested a review from bherr2 January 15, 2025 21:08
@axdanbol axdanbol linked an issue Jan 15, 2025 that may be closed by this pull request
Add back button bar #897
Closed
bherr2
bherr2 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@bherr2 bherr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is a great addition to the repository. You may merge when ready.

@axdanbol axdanbol merged commit ccef57d into develop Jan 16, 2025
10 checks passed
@axdanbol axdanbol deleted the embedding-docs-update branch January 16, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bherr2 bherr2 bherr2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add back button bar
2 participants
@axdanbol @bherr2