Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 upgrade #804

Closed
wants to merge 5 commits into from
Closed

Angular 17 upgrade #804

wants to merge 5 commits into from

Conversation

edlu77
Copy link
Contributor

@edlu77 edlu77 commented Jan 24, 2024

No description provided.

@edlu77 edlu77 requested review from axdanbol and bherr2 January 24, 2024 05:34
@edlu77 edlu77 self-assigned this Jan 24, 2024
Copy link

🚀 Preview Deploy Report

✅ Successfully deployed preview here

@bherr2
Copy link
Member

bherr2 commented Jan 24, 2024

What is the alternative to mat table exporter?

@bherr2
Copy link
Member

bherr2 commented Jan 24, 2024

Looks like maybe it doesn't use it actually. Please verify, but otherwise the build preview looks to be working.

Copy link

🚀 Preview Deploy Report

✅ Successfully deployed preview here

@edlu77
Copy link
Contributor Author

edlu77 commented Jan 24, 2024

Looks like maybe it doesn't use it actually. Please verify, but otherwise the build preview looks to be working.

It looks to be redundant, think it's safe to just get rid of it.

@bherr2
Copy link
Member

bherr2 commented Jan 24, 2024

Please fix tests

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

🚀 Preview Deploy Report

✅ Successfully deployed preview here

@bherr2
Copy link
Member

bherr2 commented Jun 14, 2024

Done in hra-ui repo

@bherr2 bherr2 closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants