-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we refresh the PRs with the PR API (and not the issues API) #1810
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5033848
Make sure we refresh the PRs with the PR API (and not the issues API)
gsmet 8ba98b4
Merge branch 'main' into refresh-prs-with-pr-api
bitwiseman 1f66efa
Update GHPullRequestTest.java
bitwiseman 16907f0
Update GHPullRequestTest.java
bitwiseman cfffe16
Update GHPullRequestTest.java
bitwiseman 8bc0bfc
Update GHPullRequestTest.java
bitwiseman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...ub/GHPullRequestTest/wiremock/refreshFromSearchResults/__files/1-orgs_hub4j-test-org.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
{ | ||
"login": "hub4j-test-org", | ||
"id": 7544739, | ||
"node_id": "MDEyOk9yZ2FuaXphdGlvbjc1NDQ3Mzk=", | ||
"url": "https://api.github.com/orgs/hub4j-test-org", | ||
"repos_url": "https://api.github.com/orgs/hub4j-test-org/repos", | ||
"events_url": "https://api.github.com/orgs/hub4j-test-org/events", | ||
"hooks_url": "https://api.github.com/orgs/hub4j-test-org/hooks", | ||
"issues_url": "https://api.github.com/orgs/hub4j-test-org/issues", | ||
"members_url": "https://api.github.com/orgs/hub4j-test-org/members{/member}", | ||
"public_members_url": "https://api.github.com/orgs/hub4j-test-org/public_members{/member}", | ||
"avatar_url": "https://avatars.githubusercontent.com/u/7544739?v=4", | ||
"description": "Hub4j Test Org Description (this could be null or blank too)", | ||
"name": "Hub4j Test Org Name (this could be null or blank too)", | ||
"company": null, | ||
"blog": "https://hub4j.url.io/could/be/null", | ||
"location": "Hub4j Test Org Location (this could be null or blank too)", | ||
"email": "[email protected]", | ||
"twitter_username": null, | ||
"is_verified": false, | ||
"has_organization_projects": true, | ||
"has_repository_projects": true, | ||
"public_repos": 26, | ||
"public_gists": 0, | ||
"followers": 2, | ||
"following": 0, | ||
"html_url": "https://github.com/hub4j-test-org", | ||
"created_at": "2014-05-10T19:39:11Z", | ||
"updated_at": "2020-06-04T05:56:10Z", | ||
"archived_at": null, | ||
"type": "Organization", | ||
"total_private_repos": 6, | ||
"owned_private_repos": 6, | ||
"private_gists": 0, | ||
"disk_usage": 12014, | ||
"collaborators": 1, | ||
"billing_email": "[email protected]", | ||
"default_repository_permission": "none", | ||
"members_can_create_repositories": false, | ||
"two_factor_requirement_enabled": false, | ||
"members_allowed_repository_creation_type": "none", | ||
"members_can_create_public_repositories": false, | ||
"members_can_create_private_repositories": false, | ||
"members_can_create_internal_repositories": false, | ||
"members_can_create_pages": true, | ||
"members_can_fork_private_repositories": false, | ||
"web_commit_signoff_required": false, | ||
"members_can_create_public_pages": true, | ||
"members_can_create_private_pages": true, | ||
"plan": { | ||
"name": "free", | ||
"space": 976562499, | ||
"private_repos": 10000, | ||
"filled_seats": 50, | ||
"seats": 3 | ||
}, | ||
"advanced_security_enabled_for_new_repositories": false, | ||
"dependabot_alerts_enabled_for_new_repositories": false, | ||
"dependabot_security_updates_enabled_for_new_repositories": false, | ||
"dependency_graph_enabled_for_new_repositories": false, | ||
"secret_scanning_enabled_for_new_repositories": false, | ||
"secret_scanning_push_protection_enabled_for_new_repositories": false, | ||
"secret_scanning_push_protection_custom_link_enabled": false, | ||
"secret_scanning_push_protection_custom_link": null, | ||
"secret_scanning_validity_checks_enabled": false | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement
await()
in some form instead of hard sleeps. Waiting is only needed when recording, not during CI tests.https://github.com/hub4j/github-api/blob/main/src/test/java/org/kohsuke/github/GHWorkflowRunTest.java#L574-L584
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is broader problem. Filed #1815.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree on that. I actually asked myself that and saw that there was some
Thread.sleep
calls above so I supposed we decided to live with them. I'll try to find some cycles to clean this up.