add job "pull-kubernetes-e2e-kubeadm-gce-ipvs" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jianhuiz , maybe be you want to take a quick look? |
|
/assign @jianhuiz |
| "--ginkgo-parallel=30", | ||
| "--kubeadm=pull", | ||
| "--kubernetes-anywhere-kubernetes-version=ci/latest", | ||
| "--kubernetes-anywhere-proxy-mode=ipvs" |
There was a problem hiding this comment.
Is this feature --kubernetes-anywhere-proxy-mode=ipvs already available in kubernetes-anywhere?
There was a problem hiding this comment.
No, that pr still not approved. That's a problem.
kubetest/anywhere.go
Outdated
| ) | ||
|
|
||
| const kubernetesAnywhereConfigTemplate = ` | ||
| .phase1.num_nodes={{.NumNodes}} | ||
| .phase1.cluster_name="{{.Cluster}}" | ||
| .phase1.ssh_user="" | ||
| .phase1.cloud_provider="gce" | ||
| .phase1.proxy_mode="{{.KubeproxyMode}}" |
There was a problem hiding this comment.
I think this Config about proxy_mode is best suited in phase2.
There was a problem hiding this comment.
Yeah, you are right, and the feature not approved yet. I need to have a full test and make some change, push into community ASAP. Thanks!
jianhuiz
force-pushed
the
huawei-test-infra
branch
from
463179c
to
eb2d700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.