Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Глаза дракона #9

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Глаза дракона #9

merged 6 commits into from
Oct 30, 2024

Conversation

rcole1919
Copy link
Contributor

@rcole1919 rcole1919 commented Oct 26, 2024 •
edited by keksobot
Loading

@keksobot keksobot changed the title add comment controller; add more methods Глаза дракона Oct 26, 2024
ElkostVN
ElkostVN reviewed Oct 29, 2024
View reviewed changes
src/rest/middlewares/validate-dto.middleware.ts Outdated
const dtoInstance = plainToInstance(this.dto, body);
const errors = await validate(dtoInstance);

if (errors.length > 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (errors.length) {

ElkostVN
ElkostVN reviewed Oct 29, 2024
View reviewed changes
src/shared/modules/offer/default-offer.service.ts Outdated
Comment on lines 27 to 28
return await this.offerModel
.exists({_id: documentId}) !== null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return this.offerModel.exists({ _id: documentId }).then(r => !!r)

@keksobot keksobot merged commit 9fd32fc into htmlacademy-nodejs-api:master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElkostVN ElkostVN ElkostVN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcole1919 @ElkostVN @keksobot