-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Микросетки на флексах для всех страниц #6
base: master
Are you sure you want to change the base?
Conversation
…", разметка отображения карточек+нумерация страниц
Оптимизация картинок |
Catalog.html
Outdated
<div class="infrastructure"> | ||
<input type="checkbox" name="infrastructure" value="pool" id="infrastructure-pool" checked> | ||
<input type="checkbox" name="infrastructure-pool" value="pool" id="infrastructure-pool" checked> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В checkbox используй один name, при выборе значений, будет происходит группировка по имени, то есть конечный результат name = [ список значений ]
Catalog.html
Outdated
</main> | ||
<footer class="main-footer"> | ||
<ul class="social-list"> | ||
<li class="social-list-item"> | ||
<a href="https://vk.com/htmlacademy"><img src="./img/social_vk.svg" width="24.0001" height="14" alt="VK"></a> | ||
</li> | ||
<li class="social-list-item"> | ||
<a href="https://t.me/htmlacademy"><img src="./img/social _tg.svg" width="22" height="17" alt="Telegram"></a> | ||
<a href="https://t.me/htmlacademy"><img src="./img/social_tg.svg" width="22" height="17" alt="Telegram"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Названия картинок через дефис
index.html
Outdated
<div class="welcome"> | ||
<div class="welcome2"> | ||
<div class="welcome3"> | ||
</div> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Чутка перебор с вложеностью, тут мы будет использовать img, так что нам будет достаточно 1 секции и нужного тега внутри
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
добавление внутренних отступов
Catalog.html
Outdated
@@ -181,14 +188,36 @@ <h2>Подпишитесь на рассылку</h2> | |||
<input type="submit" value="Подписаться"> | |||
</form> | |||
</section> | |||
<section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это больше будет nav, так как тут у нас навигация
css/style.css
Outdated
text-decoration: none; | ||
} | ||
|
||
h1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Избегай селекторы по тегам, академия это бракует, лучше заведи общий класс
|
||
} | ||
.features-list-item{ | ||
padding: 80px 85px 80px 85px; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Стиль кода
index.html
Outdated
<p class="reasons"> Опытный персонал и качественное обслуживание!</p> | ||
<ul class="features-list"> | ||
<li class="features-list-item"> | ||
<img src="./img/advantage-icon-1.svg" alt="Жилье"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это будут иконки, то есть декоративные изображения, а не img
index.html
Outdated
</li> | ||
<li class="social-list-item"> | ||
<a href="https://www.youtube.com/user/htmlacademyru"><img src="./img/youtube.svg" width="22" height="17" | ||
<a contenteditable="youtube" href="https://www.youtube.com/user/htmlacademyru"><img src="./img/youtube.svg" width="22" height="17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так же будут иконки
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
} | ||
|
||
.page-footer-container { | ||
width: 1200px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ты можешь поставить ограничения на самом верхнем уровне, чтобы не прописывать каждому элементу + выравнивание по центру
background-color: #fff; | ||
display: flex; | ||
flex-direction: column; | ||
min-height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Используй лучше 100dvh вместо %
} | ||
|
||
.blok-1 { | ||
color: #FFFFFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В обном стиле, у тебя где-то верхний регистр, а где-то нижний
css/style.css
Outdated
display: flex; | ||
flex-wrap: wrap; | ||
background-color: #82B3D3; | ||
height: 384px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не здавай фиксированные значения высоты контентным блокам, они не пройдут проверку на переполнение, отдавай приоритет min-height, только декоративным элементам фиксируй height
css/style.css
Outdated
text-transform: uppercase; | ||
} | ||
|
||
a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Старайся избегать теги, академия это не любит, лучше класс + все общие стили на верх перенеси
img/advantage-icon3.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*-icon-3, проверь именования
index.html
Outdated
<div class="page-container"> | ||
<div class="welcome"> | ||
<div class="welcome2"> | ||
<div class="welcome3"> | ||
</div> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем такая вложенность?
index.html
Outdated
</div> | ||
<ul class="features-list"> | ||
<li class="features-list-item"> | ||
<img src="./img/advantage-icon-1.svg" alt="Жилье"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сейчас это не критично, но к концу, нужно переделать на иконку, и убрать тег img, академия придерется
<svg width="23" height="18" viewBox="0 0 23 18" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
<path | ||
d="M18.9402 0.356445H3.50738C1.64668 0.356445 0.333252 1.9502 0.333252 3.75645V13.8502C0.333252 15.7627 1.64668 17.3564 3.50738 17.3564H19.1591C20.8009 17.3564 22.3333 15.7627 22.3333 13.9564V3.75645C22.1143 1.9502 20.8009 0.356445 18.9402 0.356445ZM7.99494 12.8939V4.81894L15.3283 8.85645L7.99494 12.8939Z" | ||
fill="#83B3D3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Во всех svg используй для цвета fill currentColor, это нам прогодится, при изменении состояний
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
…", разметка отображения карточек+нумерация страниц
🎓 Графика для всех страниц
🎓 Базовая стилизация всех страниц
💥 https://htmlacademy-htmlcss.github.io/2468767-sedona-1/6/
🎓 Сетка страниц и крупных блоков на флексах
🎓 Микросетки на флексах для всех страниц