Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show image overlay for direct links to media images #538

Open
towerofnix opened this issue Jul 7, 2024 · 0 comments
Open

Show image overlay for direct links to media images #538

towerofnix opened this issue Jul 7, 2024 · 0 comments

Comments

@towerofnix
Copy link
Member

This is an idea from Tangle in November: #hsmusic-chat

i just realized we should make it so when you click a link (in commentary) to an image thats saved on the wiki, it should display in the image overlay

As they note, kind of like the Unofficial Homestuck Collection.

We only connected this with commentary at the time, but it's probably also appropriate for additional file lists. The browser-provided "save link as..." / "download linked file" context menu option would still work, of course, same as cover artworks. (Lan, #hsmusic-chat)

Maybe a pictograph for an image would also be appropriate: they are links for going somewhere to view a thing (not to take an action on the page - #211), but they show that differently than normally following a link (sort of like external links - #449).

On the technical end, linkAlbumAdditionalFile - used by additional files - and linkPathFromMedia - used by transformContent - are currently unrelated components. If we want the new behavior in both contexts, we should make a code connection here. The image overlay generally shows thumbnails, so we need to provide the same relevant information as the image component does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant