Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use javascript to make a calendar #67

Merged
merged 6 commits into from
May 21, 2023
Merged

Use javascript to make a calendar #67

merged 6 commits into from
May 21, 2023

Conversation

reinhrst
Copy link
Collaborator

Fixes #58

@reinhrst reinhrst marked this pull request as ready for review May 20, 2023 16:29
@reinhrst reinhrst requested a review from DoomHammer May 20, 2023 16:29
@DoomHammer
Copy link
Member

Great job!

Do we wanna keep the alphabetical list at the bottom as well?

We definitely need a CSS wizard for this. I mean the visual CSS wizard, not the "I bet I can do it without using JS" CSS wizard.

@maknetaRo ?

@reinhrst
Copy link
Collaborator Author

Hey, I AM an CSS wizard... just not very good at knowing what I want the results of my spells to be :).

Can I merge this to the event-calendar branch? We have #59 to make things beautiful :).

I'm happy to remove the alphabetical list, however then I can imagine that we would want some sort of "archive" function -- sounds to me like something we can easily do after the MVP.

@DoomHammer
Copy link
Member

I think it's fine. And the most important thing is: definitely better than what we had before :)

@reinhrst reinhrst merged commit c296ad3 into hs3city:event-calendar May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants