made sure to only sure strings as json keys

hpi-swa-teaching · Jul 4, 2024 · ee88dde · ee88dde
1 parent 9735ac5
commit ee88dde
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/Squello-Core.package/SPBBoard.class/instance/asJson.st b/Squello-Core.package/SPBBoard.class/instance/asJson.st
@@ -4,5 +4,5 @@ asJson
 	^ JsonObject fromAssociations: {
 		'title' -> self boardName.
 		'currentID' -> self boardProvider currentID.
-		'columns' -> (JsonObject fromAssociations: (self columns collect: [:each| each id -> each asJson])).
+		'columns' -> (JsonObject fromAssociations: (self columns collect: [:each| each id asString -> each asJson])).
 	}.
diff --git a/Squello-Core.package/SPBBoard.class/methodProperties.json b/Squello-Core.package/SPBBoard.class/methodProperties.json
@@ -17,7 +17,7 @@
 		"addColumn" : "mcr 8/4/2022 00:40",
 		"addColumnLocal:" : "lo 8/3/2022 12:34",
 		"applyUserInterfaceTheme" : "AH 6/20/2024 16:20",
-		"asJson" : "FP 7/4/2024 12:13",
+		"asJson" : "FP 7/4/2024 15:46",
 		"boardName" : "FP 6/25/2024 12:13",
 		"boardName:" : "FP 6/25/2024 12:13",
 		"boardProvider" : "jh 7/29/2022 11:34",

diff --git a/Squello-Core.package/SPBLocalBoardProvider.class/instance/createCardsFromColumn..st b/Squello-Core.package/SPBLocalBoardProvider.class/instance/createCardsFromColumn..st
@@ -2,7 +2,7 @@ cards
 createCardsFromColumn: aSPBColumn 
 
 	| cardsJson |
-	cardsJson := ((self boardJson at: 'columns') at: aSPBColumn id) at: 'cards'.
+	cardsJson := ((self boardJson at: 'columns') at: aSPBColumn id asString) at: 'cards'.
 
 	cardsJson
 		do: [:cardJson | SPBCard buildFromLocal: cardJson into: aSPBColumn].
diff --git a/Squello-Core.package/SPBLocalBoardProvider.class/methodProperties.json b/Squello-Core.package/SPBLocalBoardProvider.class/methodProperties.json
@@ -8,7 +8,7 @@
 		"addLabel:toCard:" : "FP 5/23/2024 10:33",
 		"boardJson" : "FP 6/25/2024 14:24",
 		"boardJson:" : "FP 7/4/2024 12:18",
-		"createCardsFromColumn:" : "FP 7/4/2024 12:04",
+		"createCardsFromColumn:" : "FP 7/4/2024 15:47",
 		"createColumn:" : "FP 5/23/2024 10:37",
 		"createNewCard:into:" : "FP 5/23/2024 10:27",
 		"currentID" : "FP 7/4/2024 12:13",

diff --git a/Squello-Tests.package/SPBJsonSaveTests.class/instance/testBoardToJson.st b/Squello-Tests.package/SPBJsonSaveTests.class/instance/testBoardToJson.st
@@ -7,5 +7,5 @@ testBoardToJson
 	self assert: (json at: 'currentID') equals: 2.
 	columns := json at: 'columns'.
 	self assert: columns keys isCollection.
-	self assert: ((columns at: 88888888) at: 'name') equals: 'this is the second column'.
-	self assert: ((columns at: 8008531) at: 'name') equals: 'here is a column title'.
+	self assert: ((columns at: '88888888') at: 'name') equals: 'this is the second column'.
+	self assert: ((columns at: '8008531') at: 'name') equals: 'here is a column title'.
diff --git a/Squello-Tests.package/SPBJsonSaveTests.class/methodProperties.json b/Squello-Tests.package/SPBJsonSaveTests.class/methodProperties.json
@@ -12,7 +12,7 @@
 		"defaultLabel" : "FP 6/25/2024 11:28",
 		"defaultLabel2" : "FP 6/25/2024 11:32",
 		"testAssigneeToJson" : "FP 6/25/2024 11:29",
-		"testBoardToJson" : "FP 7/4/2024 12:12",
+		"testBoardToJson" : "FP 7/4/2024 15:46",
 		"testCardToJson" : "FP 6/25/2024 11:54",
 		"testColumnToJson" : "FP 6/25/2024 15:34",
 		"testLabelToJson" : "FP 6/25/2024 11:29" } }